Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed_transitions in allennlp_light.modules.conditional_random_field.__init__.py #5

Open
tchayintr opened this issue Sep 8, 2023 · 0 comments

Comments

@tchayintr
Copy link

I am working a class that inherits ConditionalRandomField class from allennlp_light.modules.conditional_random_field.

I think it would be more flexible if the allowed_transitions function is allowed to be imported like from allennlp_light.modules.conditional_random_field import allowed_transitions.

I did go through the original https://github.com/allenai/allennlp, they already did it.

allenai/allennlp#5695
allenai/allennlp#5697
allenai/allennlp#5706

Although this will be a small patch, I think there will be many parts we still can update and improve from time to time.

If you agree to update, I can PR this small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant