Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL containing special characters #185

Closed
bzwei opened this issue Jun 16, 2016 · 4 comments
Closed

URL containing special characters #185

bzwei opened this issue Jun 16, 2016 · 4 comments

Comments

@bzwei
Copy link
Contributor

bzwei commented Jun 16, 2016

Issue #183 and PR #184 seems not solving the issue with URL containing special characters. The encoding attempt only stops RestClient from complaining about the format of the URL, but the actual request using the encoded URL does not get back properly.

A further investigation may require a conversation with Microsoft concerning the format of URL if it contains special character (in the case of https://bugzilla.redhat.com/show_bug.cgi?id=1346034, { and }).

@bzwei
Copy link
Contributor Author

bzwei commented Jun 16, 2016

@djberg96 Do you have a chance to escalate this question to Microsoft? The sample URL is https://sandboxrg4183.blob.core.windows.net/wahv19c04becbc71f39b18/copied-{05A9192A-07E7-467E-878E-660BF9F68A74}.vhd

@djberg96
Copy link
Collaborator

We should be able to simulate that by renaming one of our own private images. We can see what the CLI does, too.

@djberg96
Copy link
Collaborator

As discussed on skype, there are two places that need fixing. First, is the constructor for azure-signature, which I will update to automatically escape the first argument. The second will require an internal change in the azure-armrest gem when building headers.

@bzwei
Copy link
Contributor Author

bzwei commented Jun 17, 2016

The fix by #184 is sufficient in azure-armrest.
ManageIQ/azure-signature#2 fixes azure-signature.

@bzwei bzwei closed this as completed Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants