Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way for building instance types list #302

Closed
jameswnl opened this issue Sep 21, 2017 · 10 comments
Closed

A better way for building instance types list #302

jameswnl opened this issue Sep 21, 2017 · 10 comments
Labels

Comments

@jameswnl
Copy link
Contributor

jameswnl commented Sep 21, 2017

Currently we are using this rake task which also involve pre-rake manual steps to retrieve info from multiple website.

This procedure has to be done before each MIQ release. In between releases, user now can use this (yet to be released) mechanism to capture new instance types which missed the release train.

A better solution will be a web service that is always available to allow MIQ to retrieve. (Similar to what Azure has)

What we can do for now is to

  1. contribute to https://github.com/powdahound/ec2instances.info to enhance its json output to contain what we need

  2. Adapt and move the logic in this rake task to the ManageIQ::Providers::Amazon::CloudManager::RefreshParser.get_flavors and/or ManageIQ::Providers::Amazon::InstanceTypes.instance_types

  3. (MIQ would need access to http://www.ec2instances.info/)

I have 2 PRs moving in that direction.

@jameswnl
Copy link
Contributor Author

@durandom @bronaghs @blomquisg FYI...

@juliancheal
Copy link
Member

I love the idea, but don't like the thought of going to a third party.

@jameswnl
Copy link
Contributor Author

@juliancheal yeah, I agree it's not ideal to depend on a 3rd party. But we have been depending on the same 3rd party, ec2instances.info (since day 1?).

Plus, this 3rd party is open source and it is depending on AWS's published html.

@juliancheal
Copy link
Member

@jameswnl oh, I thought we read it direct from AWS's published pages.

@juliancheal
Copy link
Member

@jameswnl as ec2instances.info is open source, could we mirror it?

@miq-bot
Copy link
Member

miq-bot commented Apr 2, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Apr 2, 2018
@juliancheal
Copy link
Member

@jameswnl are we still pursuing this?

@jameswnl
Copy link
Contributor Author

@juliancheal closing this because #396 seems a simpler approach.

@juliancheal
Copy link
Member

@jameswnl I had a feeling @AlexanderZagaynov would have a solution :)

@AlexanderZagaynov
Copy link
Contributor

yeah, there is the first one #436
and if everyone likes that approach, I'll do the PRs for two other related issues too in the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants