Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioning input data partially lost #2835

Open
kruge002 opened this issue Nov 27, 2017 · 9 comments
Open

Provisioning input data partially lost #2835

kruge002 opened this issue Nov 27, 2017 · 9 comments

Comments

@kruge002
Copy link
Contributor

We notice partial loss of input data at the Provisioning form when clicking a radio button (form refreshing) within a few seconds after entering data at an input field. A timer wheel shows and the form refreshes but the last few characters typed are gone.

We are using Fine-3.

Steps to reproduce the error:

  1. Go to "Compute" - "Infrastructure" - "Virtual Machines" and click "Lifecycle - Provision VMs".
  2. Select a template and click "Continue".
  3. Select the "Hardware" tab.
  4. Place the cursor in the field "CPU (Mhz)".
  5. Hold the mouse above an empty radio button of the field "Disk format".
  6. Type a few digits, wait a few seconds and type some more digits in the field "CPU (Mhz)" directly followed by clicking on the empty radio button.
  7. As you will see the most recently entered digits are lost.
  8. Now retype a number in the field "CPU (Mhz)" and wait a few seconds.
  9. Again click an empty radio button of the field "Disk format".
  10. As you will see the entered digits are still there.

When typing at a lower pace you sometimes see that the first digits are saved and the last few entered digits are lost when directly after entering the digits the empty radio button is clicked.

The same problem happens on e.g. the Customization tab where a users enters a password and immediately after clicks the DHCP/Static radio button. This results in an unusable VM because the password the user entered is not the same as what is saved in manageIQ.

Investigation:
Each input field has a property "data-miq_observe={interval:0.5, url:/miq_request/prov_field_changed/new}".
Using Fiddler web debugging we see the above url is repeatedly requested containing the updated value of the input field. So each update of the Provisioning form is sent to the server when the user stops typing for 0.5 seconds or more.
When the radio button is updated quickly after entering data into an input field the serverside formdata is not yet updated when the radio button update request arrives at the server and refreshes the form. The form is updated using not yet updated serverside formdata. This results in the loss of data entered right before clicking the radio button.

@miq-bot
Copy link
Member

miq-bot commented May 28, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label May 28, 2018
@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@kruge002 is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

@kruge002
Copy link
Contributor Author

kruge002 commented Jan 28, 2019

@JPrause I have just checked the issue in the Gaprindashvili release of ManageIQ so I believe this is still a problem. I cannot remove the stale label because my privileges are too restricted for that. Please add the "bug" label and the "Gaprindashvili" label.

@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

Thanks @kruge002
@miq-bot remove_label stale
BTW, Hammer is now release GA, so that can also be checked.
http://manageiq.org/download/

@miq-bot miq-bot removed the stale label Jan 28, 2019
@kruge002
Copy link
Contributor Author

kruge002 commented Jan 29, 2019

@JPrause When testing the Hammer release I noticed the issue is still present so the bug is not yet fixed.

The data as entered in the frontend form should be leading, not the data that is posted to the backend every 0.5 seconds after any keypress. This way of processing form data is asking for trouble.

@JPrause
Copy link
Member

JPrause commented Jan 29, 2019

Thanks @kruge002 for checking the Hammer release. I removed the stale label so this will get another lease on life.

@miq-bot miq-bot added the stale label Aug 5, 2019
@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants