Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listnavs: have a test of each of them #2912

Open
miq-bot opened this issue Dec 3, 2017 · 9 comments
Open

Listnavs: have a test of each of them #2912

miq-bot opened this issue Dec 3, 2017 · 9 comments

Comments

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2017

As a follow up on #5521, we want to make sure that each of the listnav views has at least one simple test.

Make sure:

  1. it renders (no 500)
  2. it renders the correct partial

This issue was moved to this repository from ManageIQ/manageiq#6324, originally opened by @martinpovolny

@miq-bot
Copy link
Member Author

miq-bot commented Jun 4, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@martinpovolny is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

@martinpovolny
Copy link

I would appreciate if you could stop doing this. You are practically creating unplanned work for me and giving me a week deadline.

This is really not helpful.

Thank you!

@JPrause
Copy link
Member

JPrause commented Jan 31, 2019

@martinpovolny perhaps there's a misunderstanding, I am not saying these "stale" issues need to be resolved within a week. All I'm asking is if this issue is valid.

I am more than happy to remove the stale label for you, or if necessary close the issue. I can also add the "pinned" label, which will prevent the "stale" label from being added in the first place.

@martinpovolny
Copy link

I have ~30 issues like that from you in my queue.

Checking if 30 issues are valid is not a 5 minute work. Some issues might be 5 minutes of work. Others may need reading the sources and others require communicating with other people. With some issues I need to update the documents I maintain on various tasks on the UI.

I'd really apprectiate if you stop doing this to issues that belong to me.

It there's a need to walk through the issues until some deadline. We can discuss that and I can plan for it.

@martinpovolny
Copy link

This particual issue is still valid. Low test coverage of the UI code is a permanent source of regression BZs. Does someone have spare cycles to work on these tests?

@ZitaNemeckova
Copy link
Contributor

Adding some in #5218

@miq-bot miq-bot added the stale label Aug 5, 2019
@miq-bot
Copy link
Member Author

miq-bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot
Copy link
Member Author

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants