Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical infrastructure: problematic partials #3492

Closed
martinpovolny opened this issue Feb 28, 2018 · 0 comments
Closed

Physical infrastructure: problematic partials #3492

martinpovolny opened this issue Feb 28, 2018 · 0 comments
Assignees

Comments

@martinpovolny
Copy link
Member

martinpovolny commented Feb 28, 2018

The TextualSummaries are done in a generic way with a handful of more or less generic formatting partials.

However the physical infra Summary pages include 2 partials that break this rule:

app/views/physical_server/_textual_network_adapter_table.html.haml
app/views/physical_server/_textual_firmware_table.html.haml

These partials don't have very complex formatting and most likely could have been implemented using the existing formatting partials.

Also these partials don't follow the i18n practices (are not properly internationalized).

@AparnaKarve : can you, please, take care of this? I don't have example data for the physical infra and you have been the one reviewing PRs introducing these partials.

Related PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants