Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hawkular/middleware code #6268

Closed
himdel opened this issue Oct 3, 2019 · 2 comments · Fixed by #7111
Closed

Remove hawkular/middleware code #6268

himdel opened this issue Oct 3, 2019 · 2 comments · Fixed by #7111
Assignees

Comments

@himdel
Copy link
Contributor

himdel commented Oct 3, 2019

Hawkular support was removed long ago, but we still have code referencing it.

@skateman started by removing all the middleware files, (#3897)

but we still have 105 hawkular mentions in the UI code, and 192 middleware mentions.
(Some of which are js middleware, but not a lot.)

Related to:

EDIT: for clarity - only middleware hawkular is being removed. Hawkular is also a valid openshift container metrics setting, that's staying

@himdel
Copy link
Contributor Author

himdel commented Dec 16, 2019

more progress in #6548

@himdel
Copy link
Contributor Author

himdel commented Dec 16, 2019

Remaining files with middleware:

$ find | grep middleware | grep -v node_modules | grep -v miq-redux
./spec/javascripts/fixtures/json/toolbar_middleware_server_detail.json
./spec/javascripts/fixtures/json/toolbar_middleware_server_list.json

remaining files with hawkular - none, hawkular_proxy_service.rb is kubernetes metrics capture and thus still used.

We still have 97 hawkular occurences in code, and about 113 middleware refences (skipping miq-redux code, which refers to different middleware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants