Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing react component: expression editor #6835

Open
himdel opened this issue Apr 3, 2020 · 6 comments
Open

Missing react component: expression editor #6835

himdel opened this issue Apr 3, 2020 · 6 comments

Comments

@himdel
Copy link
Contributor

himdel commented Apr 3, 2020

Expression editor, rendered from the layouts/exp_editor partial (app/views/layouts/_exp_editor.html.haml).

Found in:

caller menu issue
app/controllers/application_controller/filter.rb internal - exp_button / exp_token_pressed rerender -
app/views/miq_ae_class/_method_form.html.haml:69
app/views/layouts/_filter_expression.html.haml:16
app/views/layouts/_adv_search_body.html.haml:17 advanced search #6948
app/views/report/_form_filter.html.haml:18,33
app/views/miq_policy/_alert_details.html.haml:156
app/views/miq_policy/_form_scope.html.haml:4
app/views/miq_policy/_form_expression.html.haml:10
app/views/miq_policy/_policy_details.html.haml:63

the views above not only include exp_editor but often also render a part of the view.

Configuration >> Access Control; Groups / Configuration / Add a new group #6905
Automation > Automate > Customization >> Buttons; Add/Edit Button/ButtonGroup #6910
Control > Explorer >> Policies; Add/Edit #6913
Contro > Explorer >> Conditions; Add/Edit #6914

Per column operators: MiqExpression.get_col_operators, MiqExpression.model_details
selections in UI ExpAtomHelper,

@himdel
Copy link
Contributor Author

himdel commented Apr 3, 2020

@himdel
Copy link
Contributor Author

himdel commented Aug 12, 2020

API changes in ManageIQ/manageiq-api#712

(we won't be doing autocomplete for now, but it seems we can use the proposed API to populate all the field choices)

@skateman
Copy link
Member

skateman commented Oct 2, 2020

The new component should also support accessibility, added it to the list of tasks there.

@kavyanekkalapu
Copy link
Member

@GilbertCherrie and i had a discussion with @Fryguy on this issue, some points from discussion:

  • We want to change existing UI to react and we will not be implementing auto suggest part.
  • We have WIP API PR opened ([WIP] API for expression editor  manageiq-api#712). But, it is not useful for implementing
    the current UI with multiple drop downs (each dropdown options are based on previous dropdown options selection).
  • We have to create a new api end point for expression editor which works with translations too.
  • Plan is to do conversion in pieces, in order Edit Expression part have to implement first.

@Fryguy If i miss adding anything, feel free to add more here.

@kavyanekkalapu
Copy link
Member

Opened api issue for this ManageIQ/manageiq-api#1044.

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot added the stale label Feb 27, 2023
@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants