Provider success status that is "old" should not be green

[Fryguy]

In #7709 (via PR #7719), we added showing the Last Refresh Status. One of the things we did was to show the status if it's "old", that is over some threshhold, even if successful.

Because it's presented as green everything looks ok, but the purpose of showing the old status, is that it's probably not ok. Given that it's not an error, I propose we present this as a warning with a warning icon and yellow/orange status (whichever is the more consistent color).

Here's an example of a provider that actually has a problem:

@agrare @jeffibm Thoughts?

[agrare]

Agreed I thought we did say if it was "too long ago" it would be red but clearly not

[Fryguy]

A red "success" is weird though - that's why I was thinking ⚠️ with yellow.

[agrare]

Yeah or if it has been over N days we don't display the last status

[Fryguy]

Looks like we chose 2 days as the "stale" point: https://github.com/ManageIQ/manageiq-ui-classic/pull/7719/files#diff-fb6f1bc61cb13701cac831501934375521ee1cc8c61d104ed0095192f12455d0R24

[agrare]

Ah okay so if it is stale we show a notification, but not necessarily a warn/error notification.

[jeffibm]

@agrare, @Fryguy , should we change this to yellow warning?

[agrare]

@jeffibm yes a warning would be perfect in this scenario, not necessarily and error but something the user should look at

[jeffibm]

Fixes - #8571

[Fryguy]

Closed via #8571