MiqAeClassController: style fixes #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
changed the title
martinpovolny
force-pushed
the
miq_ae_class_find
branch
from
b7b82e0
to
3ab7fbd
Compare
|
Checked commits martinpovolny/manageiq-ui-classic@42eac3d~...b11a999 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/miq_ae_class_controller.rb
|
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 13, 2017
Styling changes in ManageIQ#2004 have caused `@edit[:new][:data]` value to be set to nil which disables Validate button on screen. https://bugzilla.redhat.com/show_bug.cgi?id=1499881
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 13, 2017
Styling changes in ManageIQ#2004 have caused `@edit[:new][:data]` value to be set to nil which disables Validate button on screen. https://bugzilla.redhat.com/show_bug.cgi?id=1499881
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Nov 17, 2017
Issue was introduced in ManageIQ#2004, commit c281edf find_by_fqname was changed to use rails find_by but in this case fqname is not an actual column, find_by_fqname is an actual method in MiqAeNamespace class https://github.com/ManageIQ/manageiq/blob/cb5e0de1766fa363ecfd19715316e17053925d1e/app/models/miq_ae_namespace.rb#L20 https://bugzilla.redhat.com/show_bug.cgi?id=1510463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.