Angular: Remove all references to $http success/error in favor of $http.then()

[mtho11]

Starting with Angular version 1.6 the (deprecated) $http .success and .error has been removed and will throw errors.

Angular Github PR

This means we need search and replace any instances of this and replace with promise syntax:
$http.then(function(){ }) instead.
Also, need to check javascript tests. This needs to be done before moving to Angular 1.6.

@miq-bot add_label ui, technical debt

[mtho11]

Just FYI, from style guide - Handling Exceptions with Promises - https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#style-y082

[himdel]

@mtho11 was this closed by mistake or did you want to move this to manageiq-ui-classic?

@AparnaKarve is working on it in ManageIQ/manageiq-ui-classic#13 but it's not really done yet..

[mtho11]

@himdel it seems I closed it without creating the corresponding issue. Its added now.