STI not working correctly with subclasses across providers

[durandom]

[1] pry(main)> Authentication.subclasses.include?(ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential)
=> false

But it should be true?!

Here Rails compares with > which breaks it.

Whats even the difference between subclasses and descendants ?

My Problem is

 1) ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Refresher will perform a full refresh
     Failure/Error: raise _("%{class_name} is not a subclass of %{name}") % {:class_name => klass.name, :name => name}

     RuntimeError:
       ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential is not a subclass of
     # ./app/models/mixins/new_with_type_sti_mixin.rb:11:in `new'
     # ./app/models/authentication.rb:7:in `new'
     # ./app/models/manager_refresh/save_collection/helper.rb:100:in `create_record!'

[19] pry(main)> Authentication.new(:type => 'ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential')
RuntimeError: ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential is not a subclass of AuthUseridPassword
from /Users/hild/src/manageiq/app/models/mixins/new_with_type_sti_mixin.rb:11:in `new'
[20] pry(main)> Authentication.descendants.include?(ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential)
=> true

Maybe this can help?
rails/rails#19531

@miq-bot assign @chrisarcand
@miq-bot add_label embedded_ansible_madness

cc @blomquisg

[miq-bot]

@durandom Cannot apply the following label because they are not recognized: embedded_ansible_madness

[durandom]

please note, it's not a blocking problem yet, because I can

ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Authentication.new(:type => 'ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential')

but...

[chrisarcand]

Whats even the difference between subclasses and descendants ?

subclasses are direct subclasses
descendants are what you think they are, including subclasses of subclasses.

https://github.com/rails/rails/blob/d47b90e76c989a8f0ca32c140e9b7220da0e5edc/activesupport/lib/active_support/core_ext/class/subclasses.rb

But it should be true?!

Nope, the result is what I would expect :)

[durandom]

@chrisarcand yeah, thanks. Now the difference makes sense...

But still, why cant I do

[19] pry(main)> Authentication.new(:type => 'ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential')
RuntimeError: ManageIQ::Providers::EmbeddedAnsible::AutomationManager::NetworkCredential is not a subclass of AuthUseridPassword
from /Users/hild/src/manageiq/app/models/mixins/new_with_type_sti_mixin.rb:11:in `new'

Shouldnt the mixin check descendants?!

[chrisarcand]

It does; Authentication calls AuthUseridPassword here which causes your error. I'm not sure why this is architected how it is but are you sure you're using this API as it's intended to be used? cc/ @Fryguy

[durandom]

Ah, damn, now that you say, I remember I stumbled across this when doing the Authentication / Credential stuff...

sorry for stirring up stuff.