An error pops up when editing tags in Compute / Infra / Virtual Machines / VMs

[mfalesni]

Upstream build from Aug 10th.

1. Add a VMware infra provider
2. Go to Compute / Infra / Virtual Machines
3. Go to the VMs accordion
4. Select a vm, open its details
5. Click on Policy / Edit tags

Upon opening the edit tags form an error pops up:

If you close the message, you can edit the tags and the edits will be saved.

[himdel]

The failing request is..

POST http://localhost:3000/vm_infra/report_data

{
  "model": "manageiq/providers/infra_manager/vms",
  "active_tree": "vms_filter_tree",
  "explorer": true,
  "records[]": [10000000001250]
}

Server log..

Error caught: [TypeError] no implicit conversion of nil into String
/home/himdel/.rbenv/versions/2.3.3/lib/ruby/2.3.0/psych.rb:474:in `initialize'
/home/himdel/.rbenv/versions/2.3.3/lib/ruby/2.3.0/psych.rb:474:in `open'
/home/himdel/.rbenv/versions/2.3.3/lib/ruby/2.3.0/psych.rb:474:in `load_file'
/home/himdel/manageiq/app/models/miq_report/import_export.rb:80:in `load_from_view_options'
/home/himdel/manageiq-ui-classic/app/controllers/application_controller.rb:1656:in `get_db_view'
/home/himdel/manageiq-ui-classic/app/controllers/application_controller.rb:1531:in `get_view'
/home/himdel/manageiq-ui-classic/app/controllers/application_controller.rb:513:in `report_data'

[himdel]

The problem is that MiqReport.view_yaml_filename won't find anything and returns nil..

db = ManageIQ_Providers_InfraManager_Vm
suffix = -all_vms_and_templates

...

Only ManageIQ_Providers_InfraManager_Vm.yaml exists, so the suffix should not be there.

[himdel]

Looks like this got already fixed for templates - in ManageIQ/manageiq-ui-classic#1290.

(Which makes this related to ManageIQ/manageiq-ui-classic#1270.)

Doing a similar fix for vms => ManageIQ/manageiq-ui-classic#1957

[himdel]

@miq-bot close_issue