Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state_changed_on for metrics gap collection #18317

Open
agrare opened this issue Jan 2, 2019 · 3 comments
Open

Remove state_changed_on for metrics gap collection #18317

agrare opened this issue Jan 2, 2019 · 3 comments

Comments

@agrare
Copy link
Member

agrare commented Jan 2, 2019

The need for state_changed_on being set for metrics collection purposes is causing performance issues for refresh because the custom raw_power_state= method must be invoked in ruby code and cannot be processed by batch saving.

If there were another way to detect gaps in metrics data or remove the detection entirely then the state_changed_on column would no longer be needed.

@agrare
Copy link
Member Author

agrare commented Jan 2, 2019

cc @Fryguy

@miq-bot miq-bot added the stale label Jul 15, 2019
@miq-bot
Copy link
Member

miq-bot commented Jul 15, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@mfeifer mfeifer added pinned and removed stale labels Jan 30, 2020
@mfeifer mfeifer assigned Fryguy and unassigned agrare Jan 30, 2020
@Fryguy
Copy link
Member

Fryguy commented Mar 30, 2021

We should look into why this was added in the first place. I think it had something to do with synchronizing with the EmsRefreshCoreWorker.

@Fryguy Fryguy added the size/m label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Awaiting triage
Development

No branches or pull requests

5 participants