Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error message containing html tags #8239

Closed
vprusa opened this issue Apr 26, 2016 · 6 comments · Fixed by #8279
Closed

Wrong error message containing html tags #8239

vprusa opened this issue Apr 26, 2016 · 6 comments · Fixed by #8279
Assignees
@pilhuhn
Labels
bug providers/middleware ui

Comments

@vprusa
Copy link

vprusa commented Apr 26, 2016

On failed validation of endpoint credentials when adding new middleware provider at URL: https://{IP}/ems_middleware/new with "Validate" Button error message is shown:
Credential validation was not successful: <html><head><title>Error</title></head><body>Unauthorized</body></html>
screenshot from 2016-04-26 12-14-35
Error message should not contain HTML tags when displaying in UI.
@blomquisg blomquisg assigned pilhuhn and unassigned dclarizio Apr 26, 2016
@blomquisg
Copy link
Member

@pilhuhn can you look into how this error is being generated?

The Credential validation was not successful: is part of the standard error message when credential validation fails.

But, the html code looks like it's coming directly from the response of an API call that's checking the credential validation.

@pilhuhn
Copy link
Contributor

pilhuhn commented Apr 27, 2016 •
edited
Loading

@miq-bot add_label providers/middleware
@miq-bot remove_label providers

Returning of html is a bug in Hawkular itself.

cc @abonas @Jiri-Kremser

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2016

@pilhuhn Cannot apply the following label because they are not recognized: providers/middleware

@miq-bot miq-bot removed the providers label Apr 27, 2016
@pilhuhn
Copy link
Contributor

pilhuhn commented Apr 27, 2016

@miq-bot add_label providers/hawkular

This was referenced Apr 27, 2016
Merged
Closed
@pilhuhn
Copy link
Contributor

pilhuhn commented Apr 27, 2016

We will fix it in the client gem: hawkular/hawkular-client-ruby#58

@jkremser
Copy link
Member

I think, this is happening because of the https:// in the url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilhuhn pilhuhn

Labels
bug providers/middleware ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass the html message from the provider.
8 participants
@blomquisg @Fryguy @chessbyte @pilhuhn @jkremser @vprusa @dclarizio @miq-bot