Dashboard edit - make it possible to drop into an empty column #5622
Conversation
|
@epwinchell can you please review? Not sure if the css should be in main.scss and/or whether we have some style styling ( 😄 ) conventions I'm unaware of... |
|
Checked commit https://github.com/himdel/manageiq/commit/8c53f8fadb5d51a88a6911c6a6816a85b6f3750e with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
@himdel Can you move the styling to patternfly_overrides.scss? Main.scss is for variables and things that need to change between upstream and productized versions. Thanks. |
|
Sure, will do in the morning.. What about the 3 lines that were already there, should they stay or move as well? |
|
They're fine |
|
@dclarizio @martinpovolny @h-kataria Please review |
|
Moved to patternfly_overrides & rebased, ready.. |
Go to CI > Reports > Dashboards.. and edit a dashboard. Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels. This forces a height of at least 1 widget even if empty, in edit mode. https://bugzilla.redhat.com/show_bug.cgi?id=1287178
Dashboard edit - make it possible to drop into an empty column
Dashboard edit - make it possible to drop into an empty column Go to CI > Reports > Dashboards.. and edit a dashboard. Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels. This forces a height of at least 1 widget even if empty, in edit mode. https://bugzilla.redhat.com/show_bug.cgi?id=1288189 https://bugzilla.redhat.com/show_bug.cgi?id=1287178 (cherry picked from commit 143c22c) ManageIQ#5622 clean cherry pick See merge request !568
Go to CI > Reports > Dashboards.. and edit a dashboard.
Move all widgets out from one column.. it will be impossible to move them back, because that column will have height of 0 or 1 pixels.
This forces a height of at least 1 widget even if empty, in edit mode.
https://bugzilla.redhat.com/show_bug.cgi?id=1287178