Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbars - allow angular components as custom toolbars #64

Closed
himdel opened this issue Apr 11, 2017 · 4 comments
Closed

Toolbars - allow angular components as custom toolbars #64

himdel opened this issue Apr 11, 2017 · 4 comments
Labels

Comments

@himdel
Copy link
Contributor

himdel commented Apr 11, 2017

Right now, a custom toolbar is just ng-bind-html...

Which is unfortunate because it doesn't $compile anything so the html can't really be angulary.
.. And you can't miq_boostrap because it's a child of the toolbar element, which has already been bootstrapped.

So.. to be able to use angulary custom toolbars, we may need to add support for components, or possibly a generic "$compile this" flag..

@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@himdel himdel removed the stale label Dec 11, 2017
@himdel
Copy link
Contributor Author

himdel commented Dec 11, 2017

Still present... maybe try with ng-non-bindable (ref)

@miq-bot miq-bot added the stale label Jun 18, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 18, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@himdel
Copy link
Contributor Author

himdel commented Jun 21, 2018

Still present, but React components can be used as custom toolbars, and people tend to not use the toolbar code for custom toolbars, closing.

@himdel himdel closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants