Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility #18

Closed
wants to merge 5 commits into from
Closed

Python3 compatibility #18

wants to merge 5 commits into from

Conversation

AndreaCrotti
Copy link

Few simple fixes to support Python3 and add a tox.ini to easily test python2.7/3.3/3.4

@hobailey
Copy link
Contributor

Hi @AndreaCrotti,
Thank you very much for your work here. We've decided not to merge this because it would then force current users to upgrade their Python before they could further update their SDK but I will add a reference to your PR in the readme incase others wish to update the SDK themselves.

@hobailey hobailey closed this Nov 10, 2014
@AndreaCrotti
Copy link
Author

I'm sorry but I think you haven't understood the PR.
It makes the code work for both Python3 and Python2, it won't force ANYONE to upgrade.

I mean it's up to you, but not supporting Python3 in 2014 is almost as bad as not having a python SDK considering that none of the libraries you are using is not already been ported to Python3..

@ilrico
Copy link

ilrico commented Jan 18, 2015

I guess this guy answering to you works on a 640K RAM computer ("640K ought to be enough for anybody" kind-of answer)...
Anyway not a problem, there's plenty of other payment providers supporting python3 nowadays, just google their competitors.

@llann
Copy link

llann commented Apr 23, 2015

I really do not understand why you don't want your SDK to be comatible with Python 3 AND Python 2 (as the pull request is designed for)?

@ilrico
Copy link

ilrico commented Apr 24, 2015

@ilann : try Stripe.com for instance, their API is great, and believe me or not, compatible Python 3 (yes, really !)

@hobailey
Copy link
Contributor

Hi everyone, sorry for the lack of news. We're just getting this signed off by our developers and we'll update the SDK as soon as we can.

@hobailey hobailey reopened this Apr 24, 2015
@llann
Copy link

llann commented Apr 26, 2015

@ilrico : I didn't knew this payment platform, thanks, looks great :)
@hobailey : Good to know that you are listening and reacting to people's comments :)

@hobailey
Copy link
Contributor

hobailey commented May 5, 2015

Hello again everyone. As you can see from this commit 210c313 the SDK is now Python 2.7 and 3 compatible :-)
Thanks for your help and feedback along the way.

@hobailey hobailey closed this May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants