Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goodpractice ... covr Error in aggregate.data.frame( ... no rows to aggregate #140

Open
maurolepore opened this issue Mar 15, 2020 · 0 comments
Labels
Projects

Comments

@maurolepore
Copy link

maurolepore commented Mar 15, 2020

I have a package with no functions, only datasets. I have some regression tests but I think this doesn't matter because those tests don't map to any code in R.

covr::package_coverage() passes silently, as it has nothing really to report.

> covr::package_coverage() 
> 

I expected goodpractice::gp() to also pass, reporting whatever it has to say about my package, and maybe say nothing about my tests. Instead I get an error.

> goodpractice::gp() Preparing: covr Error in aggregate.data.frame(mf[1L], mf[-1L], FUN = FUN, ...) :    
  no rows to aggregate
>

One way I hacked this is by adding a toy function in R/, e.g.:

# R/toy.R
toy  <- function() "A hack to https://github.com/MangoTheCat/goodpractice/issues/140"

And I now see the report. Here is an image:

140

@owenjonesuob owenjonesuob added this to open in Development Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants