Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in src/util should be in namespace mv::util #566

Open
alxvth opened this issue Apr 3, 2024 · 0 comments
Open

Files in src/util should be in namespace mv::util #566

alxvth opened this issue Apr 3, 2024 · 0 comments
Labels
amendment A change to the code to improve the quality

Comments

@alxvth
Copy link
Contributor

alxvth commented Apr 3, 2024

Currently, some files in src/util define classes that are in no namespace, others use mv, mv::util or mv::gui.

I think it would be good to place all utility classes in to the mv::util namespace.

At least, we should place the two classes that are not in any ManiVault namespace yet (Timer and AbstractItemModelTester) into mv::util. Especially the Timer class has a very generic name and that might result in linker errors for plugins that also define a Timer class.

@alxvth alxvth added the amendment A change to the code to improve the quality label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment A change to the code to improve the quality
Projects
None yet
Development

No branches or pull requests

1 participant