Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other audio codecs to be used other than mp3 #60

Open
ldatmpacc opened this issue Jul 16, 2023 · 1 comment
Open

Allow other audio codecs to be used other than mp3 #60

ldatmpacc opened this issue Jul 16, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ldatmpacc
Copy link

Description of proposed feature

Currently, rendering to .webm doesn't work with manim-voiceover, as all audio files use .mp3's, which the WebM format does not support(it only supports Vorbis or OPUS).

The MP3 codec is also pretty old and really lossy, especially when compared to more modern formats like AAC, Vorbis or OPUS. On that ground, there should be a way for audio to be encoded as another format(which could be done with FFmpeg on the source files).

How can the new feature be used?

It would re-enable WebM output without having to spend extra time reencoding(and losing fidelity), which some people might prefer over having to deal with over the patented H.264/H.265 found in .mp4 files.

Additional comments

As I said before, it could easily be done using FFmpeg.

@ldatmpacc ldatmpacc added the enhancement New feature or request label Jul 16, 2023
@osolmaz
Copy link
Collaborator

osolmaz commented Jul 17, 2023

I will try and see if there is an easy way to do this in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants