Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the user with a way to customize the ffmpeg command used to render their video #1145

Closed
WampyCakes opened this issue Mar 22, 2021 · 2 comments
Labels
Suggestion Requesting a feature or change for Manim

Comments

@WampyCakes
Copy link
Contributor

Description of proposed feature

#1144 introduces a change to the ffmpeg command used to create a GIF. While it seems to handle every scene I've tested well, I am sure there will be scenes that benefit from different settings (such as a different dithering). I think that we should either provide a way to set in a script config["ffmpeg_command"] or at least providing through the config more ways to control GIF (read: ffmpeg) flags.

How can the new feature be used?

Examples of these are adjusting the current palletegen and palleteuse in #1144 or allowing the user to add flags like the following to reduce file size:

scale=320:-1:flags=lanczos

Additional comments

I am not sure of the exact form this should take regarding the dynamic properties used in the ffmpeg command. Perhaps just passing an array with placeholders and then executing exactly what the user provides would be enough. (Like interpreting file_list as the literal file_list variable)

@WampyCakes WampyCakes added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Mar 22, 2021
@leotrs
Copy link
Contributor

leotrs commented Mar 22, 2021

I am not opposed to this, but it sounds like it will require some non-trivial refactoring of scene_file_writer.

Dynamic properties can already be achieved for paths saved in config (see ManimConfig.get_dir).

@WampyCakes
Copy link
Contributor Author

This customizability would also fix #786.

@jsonvillanueva jsonvillanueva added Suggestion Requesting a feature or change for Manim and removed new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) labels Apr 17, 2021
@ManimCommunity ManimCommunity locked and limited conversation to collaborators Jun 16, 2022
@MrDiver MrDiver converted this issue into discussion #2785 Jun 16, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Suggestion Requesting a feature or change for Manim
Projects
None yet
Development

No branches or pull requests

3 participants