Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BarChart inherit from Axes instead of using Line #1703

Closed
Nikhil0504 opened this issue Jun 17, 2021 · 3 comments
Closed

Make BarChart inherit from Axes instead of using Line #1703

Nikhil0504 opened this issue Jun 17, 2021 · 3 comments
Assignees
@LedMeExplain
Labels
enhancement Additions and improvements in general

Comments

@Nikhil0504
Copy link
Contributor

Enhancement proposal

The BarChart right now uses Line to draw the axes which doesn't have much flexibility. But Axes can be used for this as it can be easier and more flexible for the users to use this class and also get more features.

manim/manim/mobject/probability.py

Lines 278 to 280 in 375d9bb

def add_axes(self, width, height):
x_axis = Line(self.tick_width * LEFT / 2, width * RIGHT)
y_axis = Line(MED_LARGE_BUFF * DOWN, height * UP)

Additional comments
@Nikhil0504 Nikhil0504 added the enhancement Additions and improvements in general label Jun 17, 2021
@hydrobeam
Copy link
Member

Sounds like a good idea

@LedMeExplain
Copy link
Contributor

I think the same as you. Barchart should inherit from Axes. I'll try to fix this and make a PR

@LedMeExplain LedMeExplain mentioned this issue Aug 15, 2021
Closed
3 tasks
@icedcoffeeee
Copy link
Collaborator

Done via #2387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LedMeExplain LedMeExplain

Labels
enhancement Additions and improvements in general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nikhil0504 @hydrobeam @icedcoffeeee @LedMeExplain