Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manim requirement to >=0.13.1 from ^0.13.1 #86

Merged
merged 2 commits into from Feb 3, 2022
Merged

Conversation

hydrobeam
Copy link
Member

When trying to use manim-editor with manim v0.14.0, this error would come up:

manim-editor 0.3.8 requires manim<0.14.0,>=0.13.1, but you have manim 0.14.0 which is incompatible.

This is because of the ^ before the manim version, which restricted the version a bit too much. I've changed this to a >= to include future versions too.

https://python-poetry.org/docs/dependency-specification/#caret-requirements

@@ -15,7 +15,7 @@ include = [
python = "^3.7"
Flask = "^2.0.2"
click = "^8.0.3"
manim = "^0.13.1"
manim = ">=0.13.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience I've had huge problems with the >= notation. Shouldn't this work too?

Suggested change
manim = ">=0.13.1"
manim = "^0"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For most practical reasons that works, but technically the section API PR was introduced relatively recently, so the plugin wouldn't work with older versions of manim. I chose to keep it at v0.13.1 since that was the version where manim_editor was announced in discord.

Also, when manim hits a 1.0 release this would have to be updated again, which may or may not be necessary 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually a very good point, so we can keep your idea. Could you run poetry update and then merge this?
I could do that too but this way the PR is attributed entirely to you.

@hydrobeam hydrobeam merged commit b870884 into main Feb 3, 2022
@hydrobeam hydrobeam deleted the update-dep branch February 3, 2022 17:44
@christopher-besch
Copy link
Member

Thanks a lot for the efforts, @hydrobeam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants