Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer Roulette #9

Open
Wirone opened this issue Sep 28, 2023 · 1 comment
Open

Reviewer Roulette #9

Wirone opened this issue Sep 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Wirone
Copy link

Wirone commented Sep 28, 2023

I've stumbled upon this project today and was wondering: wouldn't it be possible to implement mechanism for drawing reviewers? In larger teams it would be great if every member was involved at similar level, so this should draw reviewers considering review history and current activity. But MVP would be just ability to run command that would draw expected amount of reviewers.

List of users available for review should be configurable per project, as I don't see any reliable way based on available data (Slack channel's participant, Gitlab project's members would most probably be much wider than people interested in the MR), maybe CODEOWNERS would be closest.

What do you think?

@cicoub13
Copy link
Member

cicoub13 commented May 2, 2024

Hello and thanks for the idea, loving it ❤️

I could work on the MVP to allow drawing reviewers as an action (once you used the command /homer review <search>) like this

image

For expected number of reviewers, it can be asked in a following Slack message OR deduced from Gitlab Approval rules.

For users, it seems complex, yes.

  • CODEOWNERS seems a good idea, but Gitlab doesn't expose an easy way to match MR changes against CODEOWNERS.
  • Users of the Slack Channel could work
  • Gitlab Users with a minimum role could work

What do you think ?
cc @josselinbuils

@cicoub13 cicoub13 added the enhancement New feature or request label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants