Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Fails by simply dumping the script #30

Open
gajus opened this issue Mar 9, 2022 · 11 comments
Open

Fails by simply dumping the script #30

gajus opened this issue Mar 9, 2022 · 11 comments
Assignees
Labels
priority:critical 🔥 This is a critical priority task. Handle it as soon as possible type:bug 🪲 Something isn't working

Comments

@gajus
Copy link

gajus commented Mar 9, 2022

Here is how we have it setup:

- uses: actions/setup-node@v2
  with:
    node-version: '16'
- name: Cache node_modules
  id: node-modules-cache
  uses: mansagroup/gcs-cache-action@v1.0.2
  with:
    bucket: github-action-runner-cache
    path: node_modules
    key: node_modules-${{ hashFiles('**/yarn.lock') }}
    restore-keys: node_modules-${{ hashFiles('**/yarn.lock') }}

Here is how it fails:

Screen Shot 2022-03-08 at 7 30 55 PM

@gajus
Copy link
Author

gajus commented Mar 9, 2022

Installing zstd took it a step further.

Screen Shot 2022-03-08 at 7 46 34 PM

@gajus
Copy link
Author

gajus commented Mar 9, 2022

I think this time it is a permission issue. Whatever the issue, the real issue is that gcs-cache-action is not surfacing these errors.

@gajus
Copy link
Author

gajus commented Mar 9, 2022

I had it working for a while, but then it started failing with the same dump of script, and I have no clue how to debug it. @basilenouvellet any chance there is a quick fix for error reporting?

@gajus
Copy link
Author

gajus commented Mar 9, 2022

I am not familiar with GitHub actions SDK, but it looks like all we are missing is some sort of try..catch here:

https://github.com/MansaGroup/gcs-cache-action/blob/main/src/post.ts#L47

@jeremylvln
Copy link
Member

I will take a look tomorrow to add some error checking, sorry about that!

@gajus
Copy link
Author

gajus commented Mar 9, 2022

I will take a look tomorrow to add some error checking, sorry about that!

Thanks a lot for publishing this action. Saved a ton of time!

@jeremylvln
Copy link
Member

Hi @gajus, I've pushed on main some error checking. Let me know what do you think. If it's okay for you I'll publish a new release :)

@gajus
Copy link
Author

gajus commented Mar 14, 2022

@IamBlueSlime Could you please publish this under 1.0.3 tag?

@jeremylvln
Copy link
Member

@gajus Did you test the main branch? To not publish a version which does not work :)

@gajus
Copy link
Author

gajus commented Mar 14, 2022

I cannot. Our CI agents are configured not to allow untagged actions. It has to have a version tag in semver form and a hash.

I can try to replicate it on a public repository if that helps, though that won't be an accurate test.

@jeremylvln
Copy link
Member

I cannot. Our CI agents are configured not to allow untagged actions. It has to have a version tag in semver form and a hash.

I can try to replicate it on a public repository if that helps, though that won't be an accurate test.

Fair enough, I will publish a pre-release ASAP, if it still blocked I will publish a real one

@jeremylvln jeremylvln self-assigned this Mar 15, 2022
@jeremylvln jeremylvln added priority:critical 🔥 This is a critical priority task. Handle it as soon as possible type:bug 🪲 Something isn't working labels Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority:critical 🔥 This is a critical priority task. Handle it as soon as possible type:bug 🪲 Something isn't working
Development

No branches or pull requests

2 participants