MTLJSONAdapter initialize failed when json data contains NSCFArray

[bruceli]

My model used to work, now it failed in latest version of Mantle. My json data is from api.openweathermap.org, following is a snippet of the data.

weather =     (
            {
        description = mist;
        icon = 50n;
        id = 701;
        main = Mist;
    }
);

The key caused the failure is weather.description. I noticed the serialization failed because of following code added into the initWithJSONDictionary:modelClass:error: method recently.

        if (![value isKindOfClass:NSDictionary.class]) {
            if (error != NULL) {
                NSDictionary *userInfo = @{
                    NSLocalizedDescriptionKey: NSLocalizedString(@"Invalid JSON dictionary", @""),
                    NSLocalizedFailureReasonErrorKey: [NSString stringWithFormat:NSLocalizedString(@"%@ could not be parsed because an invalid JSON dictionary was provided for key path \"%@\"", @""), modelClass, JSONKeyPath],
                };

                *error = [NSError errorWithDomain:MTLJSONAdapterErrorDomain code:MTLJSONAdapterErrorInvalidJSONDictionary userInfo:userInfo];
            }

            return nil;
        }

Isn't this a defect?

[robb]

Can you share your +JSONKeyPathsByPropertyKey? Seems like this is related to #257

[bruceli]

Here it is.

 + (NSDictionary *)JSONKeyPathsByPropertyKey {
    return @{
             @"date": @"dt",
             @"locationName": @"name",
             @"humidity": @"main.humidity",
             @"temperature": @"main.temp",
             @"tempHigh": @"main.temp_max",
             @"tempLow": @"main.temp_min",
             @"sunrise": @"sys.sunrise",
             @"sunset": @"sys.sunset",
             @"conditionDescription": @"weather.description",
             @"condition": @"weather.main",
             @"icon": @"weather.icon",
             @"windBearing": @"wind.deg",
             @"windSpeed": @"wind.speed"
             };
}

[robb]

oh, so weather is an array with just one element? Yeah, you seem to be affected by the same regression as #257

[bruceli]

Yes, they look very similar. Please duplicate this one if needed.

[jspahrsummers]

Closing as a dupe of #257.