Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Aero Reflection image #5

Closed
TheDolphinSlayer opened this issue Jan 15, 2024 · 40 comments
Closed

Feature Request: Aero Reflection image #5

TheDolphinSlayer opened this issue Jan 15, 2024 · 40 comments
Labels
enhancement New feature or request

Comments

@TheDolphinSlayer
Copy link

In Windows Vista - Windows 7 there was this reflection image across the titlebar that would move when the window was move.

Trying to explain this the best I can, it wasn't a static image, it would move around the title bar like a shine. I'll link a video as an example!

At 6:55

https://youtube.com/watch?v=OCqhFtcr_fs&feature=shared

@Maplespe
Copy link
Owner

Maplespe commented Jan 15, 2024

I'm aware of this and I've used glass8, but I think all these things are supposed to be provided by third party themes, and I was under the impression that if you use a third party theme you can customize these things. That's why my project is called BlurGlass and not AeroGlass, my intention is not to imitate win7 exactly, so if you need it, try using a 3rd party theme Thank you.

@catneptune
Copy link

I'm aware of this and I've used glass8, but I think all these things are supposed to be provided by third party themes, and I was under the impression that if you use a third party theme you can customize these things. That's why my project is called BlurGlass and not AeroGlass, my intention is not to imitate win7 exactly, so if you need it, try using a 3rd party theme Thank you.

image
using a third party theme the reflection image does not seem to be added, maybe could be a nice feature added

@Maplespe Maplespe added the enhancement New feature or request label Jan 15, 2024
@Maplespe
Copy link
Owner

Can you send me the theme file?

@catneptune
Copy link

catneptune commented Jan 15, 2024

Can you send me the theme file?

it's aero10, also, reflection classes were removed from msstyles entirely in 8, and there isnt an in-windows way to do it

@catneptune
Copy link

aero10_seven.zip

@Maplespe
Copy link
Owner

That does seem to be the case and I will try to implement this feature.

@funn-hue
Copy link

AFAIK aero glass by big muscle doesn't use this texture from the msstyle, because it even works with stock 10 theme if you enable the reflection in the aero glass gui

@TheDolphinSlayer
Copy link
Author

I'm not familiar with how coding works, and I promise I'm not trying to rush your progress but would it help to look at BorderSkin repo on github? (Not to steal code but to get an idea how it works/reference). Its outdated code by many years so im sure there is better alternative solutions

Ignore the broken transparency, more for the way the reflection map works, godbless youtube's great compression on my videos!

https://github.com/mohamedkomalo/BorderSkin

https://www.youtube.com/watch?v=ki6pn5WdLlM

@windowsxp3790
Copy link

I'm not familiar with how coding works, and I promise I'm not trying to rush your progress but would it help to look at BorderSkin repo on github? (Not to steal code but to get an idea how it works/reference). Its outdated code by many years so im sure there is better alternative solutions

Ignore the broken transparency, more for the way the reflection map works, godbless youtube's great compression on my videos!

https://github.com/mohamedkomalo/BorderSkin

https://www.youtube.com/watch?v=ki6pn5WdLlM

Borderskin reflection is a very poor implementation

@Maplespe
Copy link
Owner

Updated.

@TheDolphinSlayer
Copy link
Author

It works great! But there are a little bit of bugs, thank you for your speed in updating it, I am very much grateful, no rush on this. Just wanted to let you know!!

2024-01-16.14-21-47.mp4

@Maplespe
Copy link
Owner

Actually it works fine on my computer, I may need to test it more.

@TheDolphinSlayer
Copy link
Author

Actually it works fine on my computer, I may need to test it more.

I've been noticing that on multi-monitor, the reflection will disappear completely on the second monitor, like my first monitor it appears fine, but once moved over to the second its gone. Same with the taskbar (Left is my first monitor with working reflection the right is my second)
image

@Maplespe
Copy link
Owner

So the problem only occurs with multiple monitors, right?

@TheDolphinSlayer
Copy link
Author

So the problem only occurs with multiple monitors, right?

I believe so

@funn-hue
Copy link

hey, the new update is great but could you add an option to increase the streaks intensity like glass8 had?

@Maplespe
Copy link
Owner

hey, the new update is great but could you add an option to increase the streaks intensity like glass8 had?

There is an AeroPeek.png file in the data folder that you can replace yourself. After replacing it, you can change something in the GUI and click Save Configuration to refresh it.

@SamueltheTechn0Kid
Copy link

How did you get the normal-sized caption buttons?

@funn-hue
Copy link

How did you get the normal-sized caption buttons?

uDWM.dll patch

@SamueltheTechn0Kid
Copy link

SamueltheTechn0Kid commented Jan 18, 2024

Strange. That patch doesn't work for me at all.

@blondedradio
Copy link

How did you get the normal-sized caption buttons?

uDWM.dll patch

What patch is this?

@funn-hue
Copy link

How did you get the normal-sized caption buttons?

uDWM.dll patch

What patch is this?

You may ask in the windhawk discord server, since I quit modding and don't have the patched files anymore

@funn-hue
Copy link

Strange. That patch doesn't work for me at all.

Apparently microsoft broke it with a new update, it causes dwm to crash and locks you out

@windowsxp3790
Copy link

Strange. That patch doesn't work for me at all.

Apparently microsoft broke it with a new update, it causes dwm to crash and locks you out

yes
in the latest 3803 update (now 3930) they broke the uDWM patch
however you can downgrade a few dwm files to previous versions and it will work

@Maplespe
Copy link
Owner

Maplespe commented Jan 19, 2024

@TheDolphinSlayer The issue should be fixed, in addition to fixing the text glowing issue. #12
Release_x64.zip

@funn-hue
Copy link

@TheDolphinSlayer The issue should be fixed, in addition to fixing the text glowing issue. #12 Release_x64.zip

the issue is fixed, but the windows are kind of glitchy, for example behind the titlebars it shows a different thing than what is actually behind. (in tool windows btw)

@funn-hue
Copy link

and the paint.net window seems to be losing the blur when its being moved, and sometimes lags when dragging

@Maplespe
Copy link
Owner

In fact it's an internal problem with dwm's built-in blur effect and we can't fix it for now. For the reflection effect problem I think it has been solved.

@funn-hue
Copy link

In fact it's an internal problem with dwm's built-in blur effect and we can't fix it for now. For the reflection effect problem I think it has been solved.

alright

@Maplespe
Copy link
Owner

I released a new version and also added an option to lower the button height to get a win7-like button style.

@SamueltheTechn0Kid
Copy link

LET'S GOOOO! Thanks!

@funn-hue
Copy link

funn-hue commented Jan 19, 2024

I released a new version and also added an option to lower the button height to get a win7-like button style.

I updated, it's ok but the reflection seems to be cut-off from windows like explorer, discord, it's ok on small ones like the run box
https://media.discordapp.net/attachments/999083687775830117/1198021671945240726/image.png?ex=65bd63a0&is=65aaeea0&hm=26b9c539a67a94018bd5e8e95fed542ef9cf0a770c407c7b2973abbba49955c5&=&format=webp&quality=lossless&width=950&height=46

when the window is at the left side of the screen its ok but when you move it more to the right it gets cut off

@Maplespe
Copy link
Owner

Is the window between 2 monitors?

@funn-hue
Copy link

Is the window between 2 monitors?

no, i'm only on 1 monitor, btw i have replaced the aeropeek picture with a solid pink color, it looks like it's only applied to 1 part of the screen and when the window leaves the area it gets cut off

https://media.discordapp.net/attachments/999083687775830117/1198025660497662063/explorer_CEPd4IaAC7.gif?ex=65bd6757&is=65aaf257&hm=ee4be7a0bb8c2979d289a3a03b94c6d61143b528cd08c648d7bd6f1e74ee00de&=&width=950&height=69

@Maplespe
Copy link
Owner

This is strange, I tested everything in a virtual machine and the bottom image should automatically stretch to full screen.
Are your monitors arranged horizontally from left to right and the left is the primary monitor?

@funn-hue
Copy link

This is strange, I tested everything in a virtual machine and the bottom image should automatically stretch to full screen. Are your monitors arranged horizontally from left to right and the left is the primary monitor?

i have it like this https://cdn.discordapp.com/attachments/999083687775830117/1198028270969561219/image.png?ex=65bd69c6&is=65aaf4c6&hm=05179cdabcaedcbf46c50e38cfd608a956abc78ba9fd04e514a1a0db9f77674d&

monitor 2 is my main monitor which i use, and monitor 1 is my laptop screen that is always off because i have the option set to display only on second monitor

@Maplespe
Copy link
Owner

I seem to have guessed why I didn't detect the enabled status of the monitor, and the program may be treating an unenabled monitor as the active monitor. So if you enable all monitors it may solve the problem.

@valkalyne
Copy link

i'm having this same issue , except that i dont have any other monitors connected to my laptop. the cutoff also appears vertically too
image

@Maplespe
Copy link
Owner

@valkalyne @nopahc4 Please go to #18 and download the new attachment, it should be fixed .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants