Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Escaping characters sent to TTS #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Escaping characters sent to TTS #94

wants to merge 1 commit into from

Conversation

tlhunter
Copy link
Collaborator

This change highlights the need for a real test suite :(

@tlhunter
WIP: Escaping characters sent to TTS
803530d 
- Fixes #90
- Fixes #93
- SEMVER: This is a MAJOR change, but since pre 1.0, can be a MINOR
oom- added a commit to oom-/say.js that referenced this pull request Aug 21, 2020
@oom-
WIP: Escaping characters sent to TTS Marak#94
196c53f 
Marak@803530d
@JamieVangeysel
Copy link

You shouldn't replace [ and ] since they are used on macOS, for example, Hello world! [[rate 400]] This text is spoken rapidly. [[volm 0.4]] This text is spoken very quiet[[rset]].
See: Apple SpeechSynthesisProgrammingGuide Table 3-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It needs to escape text. Project probably has security vulnerabilities
2 participants
@tlhunter @JamieVangeysel