update Power part #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in this commits: * add `pow` function for all Number types returning their same number type * add `Number.pow` function that accepts all type of numbers and return `Double` * makes `pow` function `infix` so that functions can use `1 pow 2` or `3.pow(4)` * `pow` now accepts all type of `Number`s like `3.5 pow 2` or `3f pow 8`
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
====================================
- Coverage 100% 92% -8%
====================================
Files 9 10 +1
Lines 68 75 +7
Branches 36 36
====================================
+ Hits 68 69 +1
- Misses 0 6 +6
Continue to review full report at Codecov.
|
|
As code coverage tool shouts - these methods should be tested. |
|
it errors because in my commit says |
|
It also shows that test coverage dropped from 100% to 92% |
|
See pull request #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this commits:
powfunction for all Number types returning their same number typeNumber.powfunction that accepts all type of numbers and returnDoublepowfunctioninfixso that functions can use1 pow 2or3.pow(4)pownow accepts all types ofNumbers like3.5 pow 2or3f pow 8or8.pow(6L)