Added a text mapper to customize number text #56
Conversation
This code introduces the TextMapper, that is a function defined by the user of this widget to map the text displayed by the widget. This way, the user can define it's own code to show a custom text instead of just a plain number.
Pull Request Test Coverage Report for Build 47
💛 - Coveralls |
|
How do I fix the coverage problem? |
|
Hi! Shouldn't the mapper map int value to string?
Add tests :) |
I let it as string to not mess with the number padding. |
|
@MarcinusX Can you give some hints about how to write the proper tests to pass the coverage analysis? |
|
Will you merge this? A single integer number picker is too limited, we need to be able to put strings into the picker. |
|
please merge this this is a required feature |
|
Is there a solution to this request? |
|
Not sure. I have to try out something , then I'll inform you
…On Wed, 26 Feb 2020, 4:09 am AlecSPB, ***@***.***> wrote:
Is there a solution to this request?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#56?email_source=notifications&email_token=ALRLMEBR2JDG6M3GUU7CPUDREWMZDA5CNFSM4IUELNN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM5ZYEI#issuecomment-591109137>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRLMEBWGBUKAFXSMJPYTHDREWMZDANCNFSM4IUELNNQ>
.
|
|
That's what I did. All values change simultaneously, it should not be so. |
|
Hey. I will merge and publish it in a few days. I'm super busy and can't put much time into this package, so all the code, tests and screenshots are very welcome! |
|
Thanks guys, god bless you
…On Sun, 1 Mar 2020, 9:28 pm Marcin Szałek, ***@***.***> wrote:
Hey. I will merge and publish it in a few days. I'm super busy and can't
put much time into this package, so all the code, tests and screenshots are
very welcome!.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#56?email_source=notifications&email_token=ALRLMEEQUMB6NKXKTL5F3OTRFKA2NA5CNFSM4IUELNN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNC6DA#issuecomment-593112844>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRLMECC34VJKAS2CPAFX4TRFKA2NANCNFSM4IUELNNQ>
.
|
|
Published as 1.2.0! |
|
Can anyone please tell me how can i use textMapper? |
Did you achieve this? |
This code introduces the TextMapper, that is a function defined by the user of this widget to map the text displayed by the widget. This way, the user can define it's own code to show a custom text instead of just a plain number.