Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the color-spill problem and Fig.2. in your paper #3

Closed
xymsh opened this issue Mar 28, 2020 · 3 comments
Closed

About the color-spill problem and Fig.2. in your paper #3

xymsh opened this issue Mar 28, 2020 · 3 comments

Comments

@xymsh
Copy link

xymsh commented Mar 28, 2020

Hi, I have read your paper on arxiv. In your paper, the color-spill problem was proposed and an example was given in Fig.2. I tried to reproduce your result in Fig.2 using the same foreground in Composition-1k dataset. But the composite image is totally different from yours. Besides, I tried to use Closed-form method to estimate a new foreground, but got a different one. My new fg is black in the area where alpha equals to zero.

So how did you composite the original foreground onto the background? And how did you re-estimate the new foreground? Can you please share your code?

Thanks!

@MarcoForte
Copy link
Owner

MarcoForte commented Mar 30, 2020

Hi the full foreground expansion effect can be achieved by setting CONST_ALPHA_MARGIN = 0.00.
Then reset the opaque foreground values, with foreground[alpha==1] = image[alpha==1]

However note that we do not use the exact code from https://github.com/MarcoForte/closed-form-matting/blob/master/solve_foreground_background.py
Since it is rather slow.
Instead we use a custom multi-level solver written in C. Which we may release in the future.

@xymsh
Copy link
Author

xymsh commented Mar 31, 2020

Thanks! Hope we can get the code soon.

@xymsh xymsh closed this as completed Mar 31, 2020
@bebory
Copy link

bebory commented Aug 13, 2021

When solve new foreground, what you set as the 'image' to 'solve_foreground_background' function?
old fg or a composed image, or others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants