-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitLab support #587
Comments
What is the status of |
The support in core is for the |
I'll carve out some time to take a look, at least to provide some gitlab usage knowledge and feedback on what needs to be done for their API. I do have a specific question - how likely are we to use a dependency specific to gitlab API (if one exists in rust, so far I only used a python implementation)? |
Thanks for that! If you want to raise a PR and you want to use a gitlab library for fast-prototyping, feel free. We can remove the dependency later. 👍 |
Suggestion: I think it would make sense for release-plz to embrace API Client libraries like: https://crates.io/crates/gitlab, https://crates.io/crates/github and https://crates.io/crates/gitea for backend support. release-plz does a great job integrating tools and manage the process, but supporting different APIs which can be moving targets shouldn't really be it's job. Also it can only support a subset of eg. auth tokens: https://gitlab.kitware.com/utils/rust-gitlab/-/blob/master/src/auth.rs?ref_type=heads#L50 as it wouldn't make sense to re-implement everything. Alas it would be handy to have it all, as provided by these libraries. |
Motivations
release-plz supports GitHub and Gitea.
I'm not familiar GitLab, so I haven't add support for it.
However if you want to use release-plz with GitLab, tell me how the integration should work.
Here are the API calls we use for GitHub and Gitea.
What's the equivalent in GitLab?
Should we create the equivalent of the GitHub action for the GitLab CI?
We need to add support for these commands:
release-plz release
(see feat(release): add GitLab support #591)release-plz release-pr
The text was updated successfully, but these errors were encountered: