Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-plz update and release-pr do not detect last released commit if crate contains symbolic link #812

Closed
MarcoIeni opened this issue Jun 7, 2023 · 0 comments · Fixed by #827
Closed

release-plz update and release-pr do not detect last released commit if crate contains symbolic link #812

MarcoIeni opened this issue Jun 7, 2023 · 0 comments · Fixed by #827
Labels
bug Something isn't working priority:high Really important. We should do this.

Comments

@MarcoIeni
Copy link
Owner

Bug description

Issue raised here.
When release-plz copies the crate to a temporary directory, it doesn't preserve the symlink, but it copies the file instead.

We use fs_extra to copy the directory. I think we need webdesus/fs_extra#15
@MarcoIeni MarcoIeni added bug Something isn't working priority:high Really important. We should do this. labels Jun 7, 2023
@MarcoIeni MarcoIeni mentioned this issue Jun 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:high Really important. We should do this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: copy symlinks MarcoIeni/release-plz
1 participant
@MarcoIeni