Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open user are able to open picture in picture lyrics #241

Closed
MarcoMadera opened this issue Dec 25, 2023 · 5 comments · Fixed by #316
Closed

Open user are able to open picture in picture lyrics #241

MarcoMadera opened this issue Dec 25, 2023 · 5 comments · Fixed by #316
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@MarcoMadera
Copy link
Owner

MarcoMadera commented Dec 25, 2023

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Play some music
  2. Picture in picture lyrics
  3. See error 'You need a premium account to use this feature' while opening pip lyrics

Expected behavior
As open user only have 30 seconds music preview, the can't enjoy the full pip lyrics experience
Do not open the pip lyrics or hide pip lyrics button for open users

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Product: open
  • Page: [e.g. /dashboard, playlist/{id}]
    Add any other context about the problem here.
@MarcoMadera MarcoMadera added bug Something isn't working good first issue Good for newcomers labels Dec 25, 2023
@mahimshridhar
Copy link
Contributor

hi, can i take this?

@MarcoMadera
Copy link
Owner Author

@mahimshridhar Yes, you can take it 😁

@mahimshridhar
Copy link
Contributor

i have raised a pr, please let me know if any change is needed.

@MarcoMadera
Copy link
Owner Author

Thank you! @mahimshridhar

There is also one more of these buttons in the lyrics normal view:

{!!document?.pictureInPictureEnabled && (

To access to it, you need to click the lyrics button next to this one
image

Or in full screen:
image

image

It is the same button for both views. My bad for not mentioning it. You can include it if you want or I can leave it for another issue

@mahimshridhar
Copy link
Contributor

Sure updated in same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants