Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose setting fields to other scripts as properties #54

Open
MarcusOtter opened this issue Dec 8, 2019 · 0 comments
Open

Expose setting fields to other scripts as properties #54

MarcusOtter opened this issue Dec 8, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MarcusOtter
Copy link
Owner

Is your feature request related to a problem? Please describe.
Many fields in the internal logic are private readonly and have to be initialized in the constructor. This works fine unless values should be changed dynamically. It also falls short when there are many variables. An example is the ErrorHandler which has at least 5 settings (_jsonSerializerOptions, _firstValidDate, _lastValidDate, 2 unnamed constants in CountIsInRange()). When implementing the count error handling, I just ignored the extensibility and set 0 and 100 as constants (bad).

Describe the feature you'd like
Turn most of these fields into properties that can be changed from any class. There's no need to be overprotective of these, there are good reasons for other classes to change them.

@MarcusOtter MarcusOtter added the enhancement New feature or request label Dec 8, 2019
@MarcusOtter MarcusOtter added this to the Nice-to-haves milestone Dec 8, 2019
@MarcusOtter MarcusOtter self-assigned this Dec 8, 2019
@MarcusOtter MarcusOtter added this to To do in Library enhancements and features via automation Dec 8, 2019
@MarcusOtter MarcusOtter modified the milestones: Future, 2.0 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant