-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Needle fails to rename thread if longer than 100 chars #173
Comments
Do they outright remove these characters from thread names, or do they remove them from the start/end? |
@nchristopher They remove them completely, "trim" was maybe not the best word to describe it |
I think we should |
To not rely on which characters Discord will strip away from the title, you mean? I think that's a reasonable idea as well. |
Why do we need to try this when we have access to string.length? I've made a PR for this. |
@c43721 because Discord strips the invalid characters after we try to set it in the title, so we have know way of knowing how long the length will be after the invalid chars are removed. But yeah, just setting it to 100 character limit is fine imo. |
Oops, this was closed by #250 |
Describe the bug
From Dayhawk#6969 on Discord:
This is a previously known bug, but I've forgotten to make an issue about it. Discord has a limitation of 100 characters, and we should warn when users try to exceed that limit. We should also make sure to do the same character removal that Discord does, for example they remove
/
,\
, and:
(and probably others). Those should be removed before checking the length, and users should be warned that they have been removed.Steps to reproduce the bug
/title
with 101 valid characters/title
with 100 characters followed by any amount of slashes, backslashes, and colonsExpected behavior
The bot should warn when users try to exceed the 100 character limit
The text was updated successfully, but these errors were encountered: