Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 Don't mention when closing a thread #188

Closed
ItsEnderium opened this issue Jun 13, 2022 · 4 comments 路 Fixed by #250
Closed

馃挕 Don't mention when closing a thread #188

ItsEnderium opened this issue Jun 13, 2022 · 4 comments 路 Fixed by #250
Labels
improvement 馃挕 Improvement suggestion

Comments

@ItsEnderium
Copy link

Describe the improvement

Instead of mentioning someone when a thread is archived, put their name instead.

Problems this improvement solves

This causes ghost pings you can't disable, which is extremely annoying.

Alternative solutions

No response

@ItsEnderium ItsEnderium added the improvement 馃挕 Improvement suggestion label Jun 13, 2022
@MarcusOtter
Copy link
Owner

The archive message can be configured with /configure message key:SUCCESS_THREAD_ARCHIVE_IMMEDIATE if you want to change it, but I hadn't thought about shadow pings. I don't think I've been getting them. How are you archiving a thread with Needle, without having the thread visible in your client? Doesn't the ping get immediately read by yourself as you have the thread open when you archive it?

@ItsEnderium
Copy link
Author

I"m on mobile, whenever i close a thread, it locks and i have to manually unarchive it to get rid of ghost pings.
Also I'll change the archive message.

@Snailedlt
Copy link

I have the same issue on mobile too.

Whenever I close the thread (via the button) I get shadow pinged, so I have to go into the archived thread, and back out, but sometimes even that doesn't remove the notification for some reason.

Would be nice if the default was that you only got pinged if someone else closed it for you. That way you know when someone closes your thread, and you don't have to get annoying pings when you close it yourself

@MarcusOtter
Copy link
Owner

Weird, I'll investigate this and see if we can figure something out. Thanks for the suggestions :)

@MarcusOtter MarcusOtter changed the title Don't mention when closing a thread 馃挕 Don't mention when closing a thread Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 馃挕 Improvement suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants