Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Title mixup across servers #290

Closed
Madis0 opened this issue Sep 2, 2022 · 7 comments
Closed

馃悰 Title mixup across servers #290

Madis0 opened this issue Sep 2, 2022 · 7 comments
Labels
confirmed bug 馃 Something isn't working

Comments

@Madis0
Copy link

Madis0 commented Sep 2, 2022

Describe the bug

A day ago I set a custom title for new threads in server 265487088349216769, channel 714133506472804354.
Today I noticed the same title on server 859124104644788234, channel 888872895881838632 (which I also manage). Note that I have not set a custom title for that channel, the only thing I edited there post-v3 was custom buttons.

Any ideas?

Steps to reproduce the bug

  1. Run /auto-thread channel: (ID 714133506472804354) reply-message: Custom message 馃敟
  2. I don't know, change other thread settings on the other server?

Expected behavior

One server should not affect the other, even if I manage both

@Madis0 Madis0 added the potential bug 馃悰 Has not been replicated yet label Sep 2, 2022
@MarcusOtter
Copy link
Owner

On face value this seems very weird as the bot will always use the guild ID and doesn't care about the person that invokes the command. Are you sure you didn't accidentally do it in the other server the other day? Can you reproduce it again if you change the title?

@Madis0
Copy link
Author

Madis0 commented Sep 2, 2022

Tried changing titles on both servers but no, cannot reproduce again.
I really don't think I did change it accidentally, because I

  • kept the log of commands ran and therefore couldn't see it there
  • used the popup where I entered the title phrase once
  • the two servers use different languages, so setting the title on the second server would not even make sense

Maybe you have some debug logs you can check?

@MarcusOtter
Copy link
Owner

I don't store any logs right now, I can only check them in real-time as they happen. I've tried reproducing and looking in the code how something like this may occur but to me I can't see how this would happen. If anyone could reproduce this let me know how!

@MarcusOtter MarcusOtter added confirmed bug 馃 Something isn't working and removed potential bug 馃悰 Has not been replicated yet labels Sep 3, 2022
@MarcusOtter
Copy link
Owner

Aha! I can reproduce it, and it makes sense :)

Basically, as soon as you open the "Custom title" modal, the bot waits for you to submit a modal and gives you 15 minutes to do so. But right now it doesn't check that the modal submit has to be in the same server. So if you open the "custom title" modal, close it, then go to another server and set a custom title there, it will apply that custom title in both servers. Thank you for reporting this! 馃帀

@c43721
Copy link
Contributor

c43721 commented Sep 4, 2022

@MarcusOtter Also assign this to me, I would like to solve this.

@MarcusOtter
Copy link
Owner

Any updates @c43721?

@MarcusOtter
Copy link
Owner

Fixed with c42f31d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug 馃 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants