Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 Archive button customization #31

Closed
Madis0 opened this issue Jan 15, 2022 · 10 comments 路 Fixed by #250
Closed

馃挕 Archive button customization #31

Madis0 opened this issue Jan 15, 2022 · 10 comments 路 Fixed by #250
Labels
improvement 馃挕 Improvement suggestion

Comments

@Madis0
Copy link

Madis0 commented Jan 15, 2022

Is your request for improvement related to a problem? Please describe.
The messages can be configured, but the archive button itself cannot be.

Describe the solution you'd like
A way to configure the archive button text, color, visibility.

Describe alternatives you've considered
Configuring only the text would help as well.

Additional context
Add any other context or screenshots about the feature request here.

@Madis0 Madis0 added the improvement 馃挕 Improvement suggestion label Jan 15, 2022
@MarcusOtter
Copy link
Owner

MarcusOtter commented Jan 15, 2022

Would love to do this. I'm wondering how we can make this as easy as possible for the user to customize. I'm thinking we could add two optional parameters to /configure autothreading: button-type and button-text, where button-text is just a custom string, and button-type can be red, blue, grey, green and hidden, matching the available types (link does not make sense here):

image
Source: https://discordjs.guide/interactions/buttons.html#button-styles

My only worry is that we will end up lots of parameters on that command in the future making it hard to use. But perhaps we can split the parameters into separate commands at that point :)

Any thoughts on this approach @Madis0? Thank you for the suggestion!

@Madis0
Copy link
Author

Madis0 commented Jan 15, 2022

But perhaps we can split the parameters into separate commands at that point :)

  • /configure autothreading channel:#channel enabled:True
  • /configure autothreading channel:#channel custom-message:Blabla
  • /configure autothreading channel:#channel archive-button text:Blabla
  • /configure autothreading channel:#channel archive-button enabled:True
  • /configure autothreading channel:#channel archive-button color:red

I would suggest mostly reusing the existing structure, and not expecting a custom-message during the creation, instead split it to a separate command.

@MarcusOtter
Copy link
Owner

Perhaps just providing a better default is fine for now? Thoughts @Madis0?
Something like this:
image

@MarcusOtter MarcusOtter mentioned this issue Feb 1, 2022
Merged
3 tasks
@Madis0
Copy link
Author

Madis0 commented Feb 1, 2022

The archive button seems cleaner, but the commands button I'm not so sure about - what is the purpose of it? What would it do when clicked?

@MarcusOtter
Copy link
Owner

MarcusOtter commented Feb 1, 2022

It does the same as /help, shows the available commands (like /title, /close, etc). Perhaps "available commands" or "all commands" would be better text for the button?

image
image
image
image

@Madis0
Copy link
Author

Madis0 commented Feb 1, 2022

Yeah, but for the user only /title is usable. So perhaps add a button 鉁忥笍 Edit title instead?

Once clicked, it would pre-fill the chatbox with "/title " (if that is possible).

@MarcusOtter
Copy link
Owner

MarcusOtter commented Feb 1, 2022

We cannot control the users' clients unfortunately, so an edit title button would be difficult as we still need text input from them. I figured seeing what the bot can do with /help is good, we can maybe even customize the output of the /help command to only show commands available to them.

The issue for this is #47

@MarcusOtter
Copy link
Owner

Also it's future-proof if/when we decide to add more commands :)

@Madis0
Copy link
Author

Madis0 commented Feb 1, 2022

Right. In that case - yes, do limit it to the commands user can actually use. And the button could be [/] Commands or [/] Actions.

@MarcusOtter
Copy link
Owner

Thanks for the feedback! I'll go with Commands to stay consistent with Discord's naming convention :)

image

I'll leave this issue open since they should probably still be configurable at some point, but making the default better has to be the first step 馃槃

@MarcusOtter MarcusOtter changed the title 馃挕 Improvement: Archive button customization 馃挕 Archive button customization Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 馃挕 Improvement suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants