Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Add confirmation dialog to the /configure default command #32

Closed
Madis0 opened this issue Jan 15, 2022 · 5 comments · Fixed by #250
Closed

💡 Add confirmation dialog to the /configure default command #32

Madis0 opened this issue Jan 15, 2022 · 5 comments · Fixed by #250
Labels
improvement 💡 Improvement suggestion

Comments

@Madis0
Copy link

Madis0 commented Jan 15, 2022

Is your request for improvement related to a problem? Please describe.
/configure default seems quite dangerous to have as a command, I don't even know if it prompts me to confirm the action. For safety's sake, it could be better to remove it.

Describe the solution you'd like
Re-use /configure message!

If the parameter is empty, the bot returns the current value:
image
Well, that message could have the reset button as well.

Even if the user clicked it by accident, they would instantly know what got reset and could recreate it right away.

Describe alternatives you've considered
N/A

Additional context
N/A

@Madis0 Madis0 added the improvement 💡 Improvement suggestion label Jan 15, 2022
@MarcusOtter
Copy link
Owner

MarcusOtter commented Jan 15, 2022

I don't even know if it prompts me to confirm the action

True, it does not. But it definitely should! Just a simple yes/no confirm dialog should be easy enough to implement and could be very useful for the bot in other commands in the future.

Re-use /configure message!

Actually, the message configuration feature is something I've been meaning to remove. Most users just want to change the language or change how verbose the bot's output is: this can be much easier with something like /configure language and /configure verbosity. If users want to customize every message individually, forking and self-hosting would be an easier alternative for sure. While I would like to maintain high customizeability I do value simplicty and catering to the "default user". A quick scan through the current configs showed that virtually no server was using customizeable messages (except for auto-threading custom messages on a per-channel basis, which I intend to keep)

Well, that message could have the reset button as well.

This is a neat idea as well. A bit trickier to implement so the confirmation dialog should be enough. If someone does accidentally delete their configuration, I do take automated backups regularly on the VPS, so one could pop into the Discord server and get it restored fairly easily 👍

@MarcusOtter
Copy link
Owner

To put it succinctly: rather than removing the default command I think we should add a confirm/cancel prompt to it with buttons. We can also add information about how to restore it (join the Discord and contact me). If it becomes a common problem, we can look into it more.

@Madis0
Copy link
Author

Madis0 commented Jan 15, 2022

If users want to customize every message individually, forking and self-hosting would be an easier alternative for sure. While I would like to maintain high customizeability I do value simplicty and catering to the "default user". A quick scan through the current configs showed that virtually no server was using customizeable messages (except for auto-threading custom messages on a per-channel basis, which I intend to keep)

I agree, it was confusing to see error messages being customizable, but I think the success messages could still stay customizable. For example, I consider the default archive success message way too verbose, so I shortened it down to one sentence.

Though, you can keep that setting per-channel (without being able to change the global option) as well, up to you.

@MarcusOtter
Copy link
Owner

MarcusOtter commented Jan 15, 2022

I'd like /configure verbosity to have something like a one-liner setting so you only get the essential stuff like you mentioned, which would be applied globally. Sounds like that would suit your use case as well. It could even have a No visible messages-setting that would only create hidden messages when replying to commands and nothing else.

Either way, thanks for bringing up the lack of confirmation on the /configure default command!

@MarcusOtter MarcusOtter changed the title 💡 Improvement: Remove the "default" command 💡 Improvement: Add confirmation dialog to the /configure default command Jan 16, 2022
@MarcusOtter MarcusOtter changed the title 💡 Improvement: Add confirmation dialog to the /configure default command 💡 Improvement: Add confirmation dialog to the /configure default command Jan 16, 2022
@ririko5834
Copy link

You can use 2 buttons with ✅ and ❌ emojis for confirmation prompts.

@MarcusOtter MarcusOtter changed the title 💡 Improvement: Add confirmation dialog to the /configure default command 💡 Add confirmation dialog to the /configure default command Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 💡 Improvement suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants