Thread safety #46
Merged
Thread safety #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Send + Sync to all the objects that are passed through the external interface, as we have no way of policing whether they are used in different threads. Fix all the compile errors that result. The effect is that all Rc containers are now Arc. This makes sense, as we really only use sharing when external users want it. For example, a user may use the same instrument and market data in different threads. It adds an overhead to cloning an Arc, but we do not do that very often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Send + Sync to all the objects that are passed through the external interface, as we have no way of policing whether they are used in different threads. Fix all the compile errors that result.
The effect is that all Rc containers are now Arc. This makes sense, as we really only use sharing when external users want it. For example, a user may use the same instrument and market data in different threads. It adds an overhead to cloning an Arc, but we do not do that very often.