Skip to content

Commit

Permalink
[CONJ-192] Correct driver metadata version
Browse files Browse the repository at this point in the history
  • Loading branch information
rusher committed Sep 4, 2015
1 parent b348bec commit 40a1c83
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 12 deletions.
20 changes: 20 additions & 0 deletions README.md
Expand Up @@ -24,6 +24,26 @@ or maven :
<version>1.2.2</version>
</dependency>
```

Development snapshot are available on sonatype nexus repository
```script
<repositories>
<repository>
<id>sonatype-nexus-snapshots</id>
<name>Sonatype Nexus Snapshots</name>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
</repository>
</repositories>
<dependencies>
<dependency>
<groupId>org.mariadb.jdbc</groupId>
<artifactId>mariadb-java-client</artifactId>
<version>1.3.0-SNAPSHOT</version>
</dependency>
</dependencies>
```

## Documentation

For a Getting started guide, API docs, recipes, etc. see the [documentation page](https://mariadb.com/kb/en/mariadb/about-the-mariadb-java-client/)!
3 changes: 1 addition & 2 deletions pom.xml
Expand Up @@ -5,7 +5,7 @@
<artifactId>mariadb-java-client</artifactId>
<packaging>jar</packaging>
<name>mariadb-java-client</name>
<version>1.2.2</version>
<version>1.3.0-SNAPSHOT</version>
<description>JDBC driver for MariaDB and MySQL</description>
<url>https://mariadb.com/kb/en/mariadb/about-mariadb-connector-j/</url>
<properties>
Expand Down Expand Up @@ -262,7 +262,6 @@
<token>@qualifier</token>
<value>${parsedVersion.qualifier}</value>
</replacement>
parsedVersion.qualifier
</replacements>
</configuration>
</plugin>
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/org/mariadb/jdbc/MySQLDatabaseMetaData.java
Expand Up @@ -61,6 +61,7 @@ WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWIS
import java.util.List;

public class MySQLDatabaseMetaData implements DatabaseMetaData {
private final static String DRIVER_NAME = "MariaDB connector/J";
private String url;
private MySQLConnection connection;
private String databaseProductName = "MySQL";
Expand Down Expand Up @@ -488,20 +489,20 @@ public String getDatabaseProductVersion() throws SQLException {


public String getDriverName() throws SQLException {
return "mariadb-jdbc"; // TODO: get from constants file
return DRIVER_NAME;
}

public String getDriverVersion() throws SQLException {
return String.format("%d.%d",getDriverMajorVersion(),getDriverMinorVersion());
return Version.version;
}


public int getDriverMajorVersion() {
return 1;
return Version.majorVersion;
}

public int getDriverMinorVersion() {
return 1;
return Version.minorVersion;
}


Expand Down
8 changes: 4 additions & 4 deletions src/main/java/org/mariadb/jdbc/Version.java
@@ -1,10 +1,10 @@
package org.mariadb.jdbc;

public final class Version {
public static final String version = "1.2.2";
public static final String version = "1.3.0-SNAPSHOT";
public static final int majorVersion = 1;
public static final int minorVersion = 2;
public static final int patchVersion = 2;
public static final String qualifier = "";
public static final int minorVersion = 3;
public static final int patchVersion = 0;
public static final String qualifier = "SNAPSHOT";

}
6 changes: 4 additions & 2 deletions src/test/java/org/mariadb/jdbc/DateTest.java
Expand Up @@ -233,13 +233,15 @@ public void javaUtilDateInPreparedStatementAsTime() throws Exception {
ps.executeUpdate();
ResultSet rs = connection.createStatement().executeQuery("select * from dtest");
rs.next();
assertEquals(d.getHours(), rs.getTime(1).getHours());

/* Check that time is correct, up to seconds precision */
assertEquals(d.getHours(),rs.getTime(1).getHours());
assertEquals(d.getMinutes(),rs.getTime(1).getMinutes());
if (isMariadbServer()) {
assertEquals(d.getMinutes(),rs.getTime(1).getMinutes());
assertEquals(d.getSeconds(), rs.getTime(1).getSeconds());
} else {
//mysql 1 seconde precision
Assert.assertTrue(Math.abs(d.getMinutes() - rs.getTime(1).getMinutes()) <= 1);
Assert.assertTrue(Math.abs(d.getSeconds() - rs.getTime(1).getSeconds())<=1);
}
}
Expand Down

0 comments on commit 40a1c83

Please sign in to comment.