Improve MariaDB driver stability in case JNA errors #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having MariaDB driver 1.5.9 on Debian 7 x86-64 we've added JNA 4.4.0 to project dependencies and got the following error:
It turned out to be a compatiblity issue in recent JNA versions (4.3.0 and 4.4.0) - java-native-access/jna#853.
The change wasn't really connected with MariaDB driver and PID functionality causing the exception seems to be optional (as well as use of JNA), nevertheless it failed the whole thing.
After looking into the code, it seems that mere catch
Throwable
instead ofException
(like it's already done for Windows part ofPidFactory
) covers cases likeUnsatisfiedLinkError
thrown from JNA and makes such failures just minor issues.