-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idea] gradual shading of repo to black #17
Comments
Yup, so what we can do is, in the commanding issuee, provide a list of files/paths to be blackened. |
Yeah, I is similar to what I do with pre-commit tool: I exclude lots of files in config and then include them. I would probably like to see this as a config in repo. |
Hm I'm not a fan of yet another configuration file. |
Well, it's the easiest way of keeping configs of all repos, where GitHub App is installed. Otherwise, you'd have to implement some per repo state management on the server side or some UI. |
So I'm thinking of providing a config file where we can specify which paths are to be blacked out. So maybe a |
I'd say |
Remark: blackening files wholesale creates unwanted side effects. I saw ppl resisting to it because it messes up authorship in |
Further ideas: use a brand-new change suggestions feature to send chunk changes on top of PRs. https://blog.github.com/2018-10-16-future-of-software/#suggested-changes-public-beta |
I think "suggesting change" is available through GitHub web UI, not through APIs. |
@Mariatta so this feature is nothing more than "```suggestion" type of the markdown code block. I bet it should work for the bot posting a comment to the position in diff. |
What I mean is that high-volume, actively developed repos it might be unable to afford reformatting of the entire code base at once.
Instead, it would be less painful and non-blocking if bot could do blackening file by file or even better - update chunks and send new PRs once previous have been merged. It could even do bigger chucks against rarely changed code at the beginning and slow down and be more picky about the code someone is currently editing.
The text was updated successfully, but these errors were encountered: