Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevalidatingInterceptor is a spin wait and not a short waiting #3676

Closed
StefanOssendorf opened this issue Feb 6, 2024 · 0 comments · Fixed by #3677
Closed

RevalidatingInterceptor is a spin wait and not a short waiting #3676

StefanOssendorf opened this issue Feb 6, 2024 · 0 comments · Fixed by #3677

Comments

@StefanOssendorf
Copy link
Contributor

StefanOssendorf commented Feb 6, 2024

Describe the bug
The implementation at

does not await the Task.Delay(1) to "wait" for the completion of the async rules. That means it's spinning this while-loop at full speed generating (probably) a lot of tasks which are ignored immediately.

Version and Platform
CSLA version: 7.0.3
OS: Windows
Platform: WPF, ASP.NET Core,

Code that Fails
Provide the failing code, ideally an isolated repro of the issue you are encountering.

Additional context
To fix this issue it's necessary to make the whole Interceptor chain async aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants