Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Condition Relabelling Functionality #325

Closed
DarioS opened this issue May 14, 2024 · 3 comments
Closed

Cell Condition Relabelling Functionality #325

DarioS opened this issue May 14, 2024 · 3 comments

Comments

@DarioS
Copy link

DarioS commented May 14, 2024

Once we have the neighbourhoods or groups, would it be a convenient to offer downstream functionality in the package? For example, let's say neighbourhood 3 is ten-fold enriched in the resistant-to-therapy condition. There are still a few cells belonging to patients who are labelled as sensitive in this group. Would it be convenient to provide a function which relabels all of the cells belonging to a neighbourhood group to the majority condition? Therefore, although each patient has only one starting label - either sensitive or resistant, after Milo analysis, they could have a proportion of cells with both condition labels. This would be useful for identifying samples with, for instance, 95% sensitive, 5% resistant cells. Or, in other words, which patients have disease that is likely to recur after treatment due to small cell subgroups which are unlikely to be killed by a therapy, based on their similarity to cells with opposite label.

@MikeDMorgan
Copy link
Member

I think this could be a field-specific analysis, and hence I would encourage you to create your own functions that take Milo/DA results and compute this. Milo is designed to facilitate DA testing, and it is necessary to be quite strict with what functionality is contained in the package because it also needs to be maintained (Heng Li I am not).

@DarioS
Copy link
Author

DarioS commented Jun 3, 2024

You mean Aaron Lun? Heng Li hasn't maintained and improved bwa in years.

@DarioS DarioS closed this as completed Jun 3, 2024
@MikeDMorgan
Copy link
Member

MikeDMorgan commented Jun 4, 2024

Heng Li's comment on software devel: http://lh3.github.io/2019/03/11/on-maintaining-bioinformatics-software

(Also, I'm sure both Aaron and I would gladly agree that I'm not Aaron having worked with him for the best part of 3 years).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants