Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS on site #15

Open
tsaoyu opened this issue May 3, 2018 · 4 comments · May be fixed by #18
Open

HTTPS on site #15

tsaoyu opened this issue May 3, 2018 · 4 comments · May be fixed by #18

Comments

@tsaoyu
Copy link
Member

tsaoyu commented May 3, 2018

GitHub pages now support HTTPS on custom domain, see here

@Nanoseb
Copy link
Member

Nanoseb commented May 3, 2018

That's great!
I just checked and for the blog it is not working properly because some links are "hardcoded" in http in the source, like the css: <link rel="stylesheet" href="http://blog.sotonsailrobot.org/css/main.css"> (so firefox will block the css from loading)

All links also redirect to the http version of the website.

@tsaoyu
Copy link
Member Author

tsaoyu commented May 8, 2018

blog.sotonsailrobot.org is now on https, but the certificate on main site still await to be issued

@Nanoseb
Copy link
Member

Nanoseb commented May 9, 2018

really? for me https://www.sotonsailrobot.org/ works all right

@zysim
Copy link
Collaborator

zysim commented Mar 2, 2022

Hi :)

Can't find the exact doc right now for some reason, but apparently for any GH Pages repo made after 15th June 2016, sites auto-redirect to HTTPS now. Tried it out on my end and it did. Verified it in the network tab as well.

We do have a few files that contain HTTP links though. I'll make a PR to swap them all to HTTPS.

EDIT: Found the page I was talking about.

@zysim zysim linked a pull request Mar 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants