Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV Values don't Update #48

Open
jpdevries opened this issue May 10, 2013 · 7 comments
Open

TV Values don't Update #48

jpdevries opened this issue May 10, 2013 · 7 comments

Comments

@jpdevries
Copy link
Contributor

jpdevries commented May 10, 2013

When set to update mode tv values do not get updated.

Steps to reproduce on a fresh MODX install with ImportX installed (assumes a tv id of 1)

  • Import a resource using:

pagetitle;alias;isfolder;tv1
Analysing;analysing;1;importxtest

  • Change importx.processor System Setting to 'update'
  • Now import (update) using:

id;pagetitle;alias;isfolder;tv1
2;Analysing2;analysing;1;importxtest2

  • Notice page title updated, but TV Value did not

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jpdevries
Copy link
Contributor Author

Been trying to track down this bug, seems like the place to look is startimport.php line 49 (where $modx->runProcessor is called for either create or update) and passes in a line element, created by csv.php

@jpdevries
Copy link
Contributor Author

Verified that on update the $lines Array returned by prepareCsv->prepareCsv() contains the correct updated TV Values and that what is being passed to $modx->runProcessor in startimport.php is correct (updated TV value). For some reason the update processor isn't saving those TV values

@jpdevries
Copy link
Contributor Author

Possibly related MODX bug:
http://tracker.modx.com/issues/5965

@adamwintle
Copy link

Any know fix/hack for this?

@KirilOkun
Copy link

+1. This is an important feature to be able to update tvs in bulk. Any progress or workarounds for this?

@Mark-H
Copy link
Member

Mark-H commented Oct 9, 2014

Did the patch in #50 (i.e. v1.1.1) not do the trick? That's the only known "fix/hack" I know off, but if that doesn't work there's probably no other way to fix this other than a big refactor to stop reusing the core processors.

@KirilOkun
Copy link

Thanks Mark.
Somehow i missed that one. Will give it a try.

All the best.

On 10/10/2014 01:36 AM, Mark Hamstra wrote:

Did the patch in #50 #50 (i.e.
v1.1.1) not do the trick? That's the only known "fix/hack" I know off,
but if that doesn't work there's probably no other way to fix this
other than a big refactor to stop reusing the core processors.


Reply to this email directly or view it on GitHub
#48 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants