Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage GitHub actions #1004

Closed
damithc opened this issue Jan 30, 2020 · 11 comments · Fixed by #1839 or #1880
Closed

Leverage GitHub actions #1004

damithc opened this issue Jan 30, 2020 · 11 comments · Fixed by #1839 or #1880
Labels
a-AuthorUsability a-DevOps s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding

Comments

@damithc
Copy link
Contributor

damithc commented Jan 30, 2020

Example: https://github.com/marketplace/actions/jekyll-action

Perhaps we can provide an action to deploy a MarkBind site to gh-pages?

@damithc damithc added a-AuthorUsability a-DevOps s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding labels Jan 30, 2020
@le0tan
Copy link
Contributor

le0tan commented Feb 2, 2020

It should be rather straight-forward to create an action similar to this. Is this issue still under discussion? (i.e. can we start working on it?)

@damithc
Copy link
Contributor Author

damithc commented Feb 2, 2020

@le0tan you can give it a try and let's see how it goes.

@le0tan
Copy link
Contributor

le0tan commented Feb 4, 2020

This is my approach.

@damithc
Copy link
Contributor Author

damithc commented Feb 4, 2020

From the user's POV, what needs to be done? i.e., how does this feature looks to the user when released?

@le0tan
Copy link
Contributor

le0tan commented Feb 4, 2020

From the user's POV, what needs to be done? i.e., how does this feature looks to the user when released?

I updated the readme here.

@damithc
Copy link
Contributor Author

damithc commented Feb 4, 2020

Just curious: can GitHub action access attributes of the PR that triggered it? e.g., PR number, labels, etc.

@le0tan
Copy link
Contributor

le0tan commented Feb 5, 2020

Just curious: can GitHub action access attributes of the PR that triggered it? e.g., PR number, labels, etc.

It has access to the Git ref that triggers the action according to here. See github.head_ref and github.base_ref.

@damithc
Copy link
Contributor Author

damithc commented Dec 14, 2020

@le0tan any chance your work can be resumed? We can host the action in a repo inside the markbind org.

@le0tan
Copy link
Contributor

le0tan commented Dec 15, 2020

@damithc the action is actually working as expected, sample repo here

Action page for that repo

Built page

Update: created the repo in MarkBind org, can someone accept the agreement so that we can publish the action?

image

@damithc
Copy link
Contributor Author

damithc commented Dec 15, 2020

@damithc the action is actually working as expected, sample repo here

Nice.

Update: created the repo in MarkBind org, can someone accept the agreement so that we can publish the action?

image

While we figure out how to do that, can you create a PR to update the user guide?

@damithc
Copy link
Contributor Author

damithc commented Dec 15, 2020

Update: created the repo in MarkBind org, can someone accept the agreement so that we can publish the action?

image

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-AuthorUsability a-DevOps s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding
Projects
None yet
2 participants